-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow qute.html extension for templates #71
Conversation
Hi @kucharzyk and thanks for the PR! Just to be clear - this PR merely fixed the problem with index pages, right? In other words, |
We should probably also update the docs: https://github.com/quarkiverse/quarkus-qute-web/blob/main/docs/modules/ROOT/pages/index.adoc?plain=1#L9. |
You have right. The problem was only for index.qute.html I will update the docs later today |
@mkouba I've mentioned that we can use There is one more thing that could be fixed later. Currently It's a bit inconsistent and I am not sure if it is intended behaviour. |
@mkouba I've added additional fix so index.qute.html should be available as |
@kucharzyk Hm, I don't think it's inconsistent. The idea is that you either use the full template name ( But it seems that we don't have a test for this use case. We should definitely add one. I'd like to merge the fix for the index page first. Would you care to revert the other fix? |
Thank you for the feedback. |
Thanks! |
@mkouba Done. I've reverted second fix |
This PR will fix issue #70 and allow using qute.html extension for templates